Thread (26 messages) 26 messages, 5 authors, 2023-03-02

Re: [PATCH v2 1/8] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC

From: Bartosz Golaszewski <hidden>
Date: 2023-02-15 15:03:01
Also in: linux-arm-kernel, linux-gpio, linux-rockchip, lkml

On Sun, Feb 12, 2023 at 5:14 PM Krzysztof Kozlowski
[off-list ref] wrote:
On 10/02/2023 21:03, Bartosz Golaszewski wrote:
quoted
On Wed, Feb 8, 2023 at 12:08 PM Linus Walleij [off-list ref] wrote:
quoted
On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker [off-list ref] wrote:
quoted
Currently all Rockchip gpio nodes have the same compatible.
Compatible strings should be SoC related.

Signed-off-by: Johan Jonker <redacted>
Bartosz can you merge this one patch and keep the rest back
so we get a more defined DT binding baseline?

Yours,
Linus Walleij
Krzysztof, you left your ack but seem to also have pointed out an
issue - do you want me to fix it up somehow before applying? Drop the
oneOf and turn it back into an enum?

Sure, you can apply with my comment fixed but then just please check
with `make dt_binding_check DT_SCHEMA_FILES="xxx.yaml"`, that
indentation is not mixed up.

Best regards,
Krzysztof
I prefer to get your ack on the final version really.

Johan, please address the enum issue and resend just this patch.

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help