Re: [PATCH 2/3] dt-bindings: hwlock: sun6i: Add missing names
From: Andre Przywara <andre.przywara@arm.com>
Date: 2023-02-14 00:14:24
Also in:
linux-arm-kernel, linux-remoteproc, linux-sunxi, lkml
On Tue, 14 Feb 2023 00:19:29 +0100 Bastian Germann [off-list ref] wrote:
The allwinner,sun6i-a31-hwspinlock.yaml binding needs clock-names and reset-names set to "ahb" as required by the driver.
That should read "Linux driver", and is technically not a good rationale to change a DT binding, but I guess the Linux kernel is the only user so far, so the change should be fine:
Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
Signed-off-by: Bastian Germann <redacted>Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre
quoted hunk ↗ jump to hunk
--- .../hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index 01b1bbb3061f..1f11d9580646 100644 --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml@@ -23,9 +23,17 @@ properties: clocks: maxItems: 1 + clock-names: + items: + - const: ahb + resets: maxItems: 1 + reset-names: + items: + - const: ahb + '#hwlock-cells': const: 1@@ -33,7 +41,9 @@ required: - compatible - reg - clocks + - clock-names - resets + - reset-names - "#hwlock-cells" additionalProperties: false