Re: [PATCH] dt-bindings: mmc: Add cap-aggressive-pm property

On 30/01/2023 07:54, Hermes Zhang wrote:

On 2023/1/29 18:58, Krzysztof Kozlowski wrote:

quoted

On 29/01/2023 03:36, Hermes Zhang wrote:

quoted

This commit add a new property: cap-aggressive-pm to enable the

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Done

quoted

quoted

MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Why this is a property suitable for DT? IOW, why this isn't enabled always?

This property will benfit for the power consumption, but it also may 
degradation in performance as it will prevent the

the card from executing internal house-keeping operations in idle mode. 
So it's better to config it from DT.

Why? DT is not for policy. How you described it, this is policy or
system tuning choice thus the job for Linux (OS), not for DT. So I will
repeat - why this property fits the purpose of DT (describe the hardware).

Best regards,
Krzysztof