Hi Krzysztof,

On Tue, Nov 15, 2022 at 2:16 PM Krzysztof Kozlowski
[off-list ref] wrote:

On 14/11/2022 12:15, Herve Codina wrote:

quoted

Add the USBF controller available in the r9a06g032 SoC.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 arch/arm/boot/dts/r9a06g032.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
index 563024c9a4ae..a4bb069457a3 100644
--- a/arch/arm/boot/dts/r9a06g032.dtsi
+++ b/arch/arm/boot/dts/r9a06g032.dtsi

@@ -117,6 +117,18 @@ dmamux: dma-router@a0 {
                      };
              };

+             udc: usb@4001e000 {
+                     compatible = "renesas,r9a06g032-usbf", "renesas,rzn1-usbf";
+                     reg = <0x4001e000 0x2000>;
+                     interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
+                                  <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
+                     clocks = <&sysctrl R9A06G032_HCLK_USBF>,
+                              <&sysctrl R9A06G032_HCLK_USBPM>;
+                     clock-names = "hclkf", "hclkpm";
+                     power-domains = <&sysctrl>;
+                     status = "disabled";

If you provided all resources (clocks, power domains etc), why disabling it?

Doesn't this depend on wiring on the board, and providing pin control
in the board DTS?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds