Re: [PATCH 11/15] scsi: ufs: ufs-qcom: Use dev_err_probe() for printing probe error
From: Dmitry Baryshkov <hidden>
Date: 2022-10-29 21:33:20
Also in:
linux-arm-msm, linux-phy, linux-scsi, lkml
On 29/10/2022 17:16, Manivannan Sadhasivam wrote:
quoted hunk ↗ jump to hunk
Make use of dev_err_probe() for printing the probe error. Signed-off-by: Manivannan Sadhasivam <redacted> --- drivers/ufs/host/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 8bb0f4415f1a..28ac5f0ab2bc 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c@@ -1441,7 +1441,7 @@ static int ufs_qcom_probe(struct platform_device *pdev) /* Perform generic probe */ err = ufshcd_pltfrm_init(pdev, &ufs_hba_qcom_vops); if (err) - dev_err(dev, "ufshcd_pltfrm_init() failed %d\n", err); + dev_err_probe(dev, err, "ufshcd_pltfrm_init() failed\n");
What about:
if (err)
return dev_err_probe(....);
return 0;
return err; }
-- With best wishes Dmitry