Re: [PATCH 08/12] ASoC: mediatek: mt8188: add platform driver

On Thu, 2022-10-06 at 10:48 +0800, Trevor Wu wrote:

On Tue, 2022-10-04 at 11:36 +0200, AngeloGioacchino Del Regno wrote:

..snip

quoted

quoted

+#include "mt8188-afe-common.h"
+#include "mt8188-afe-clk.h"
+#include "mt8188-reg.h"
+#include "../common/mtk-afe-platform-driver.h"
+#include "../common/mtk-afe-fe-dai.h"
+
+#define MTK_SIP_AUDIO_CONTROL MTK_SIP_SMC_CMD(0x517)

This definition goes to include/linux/soc/mediatek/mtk_sip_svc.h

Hi Angelo,

If I move the definition to
"include/linux/soc/mediatek/mtk_sip_svc.h",
I should submit it to another tree.
In the case, do you have any suggestion to handle the dependent
problem?

quoted

quoted

+

Hi Angelo,

I found ohter MTK drivers[1][2] also put the definition under module
driver insted of mtk_sip_svc.h.

I still prefer to put the definition under sound/soc/mediatek in case
of dependency problem, but I will move it to
sound/soc/mediatek/common/mtk-afe-base.h in v2 becasue this is common
for MTK sound driver.

Thanks,
Trevor

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?h=next-20221014#n37

[2] 
https://elixir.bootlin.com/linux/latest/source/drivers/ufs/host/ufs-mediatek.h#L83