Re: [PATCH 2/6] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
From: Krzysztof Kozlowski <hidden>
Date: 2022-09-01 15:11:40
Also in:
asahi, linux-arm-kernel, linux-gpio
On 01/09/2022 16:54, Russell King (Oracle) wrote:
quoted hunk ↗ jump to hunk
Add the DT binding for the Apple Mac System Management Controller GPIOs. Signed-off-by: Russell King (Oracle) <redacted> --- .../devicetree/bindings/gpio/gpio-macsmc.yaml | 28 +++++++++++++++++++ .../devicetree/bindings/mfd/apple,smc.yaml | 4 +++ 2 files changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-macsmc.yamldiff --git a/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml new file mode 100644 index 000000000000..ee620fe50ca8 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml@@ -0,0 +1,28 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#
filename based on the compatible... which is missing here, so this leads to the question - why this is separate device/child node? It won't bind to anything, won't be populated, right?
quoted hunk ↗ jump to hunk
+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller GPIO + +maintainers: + - Hector Martin [off-list ref] + +description: + This describes the binding for the Apple Mac System Management Controller + GPIO block. + +properties: + gpio-controller: true + '#gpio-cells': + const: 2 + +additionalProperties: false + +examples: + - | + smc_gpio: gpio { + gpio-controller; + #gpio-cells = <2>; + };diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml index 794d3a6eb04a..bb799a27638d 100644 --- a/Documentation/devicetree/bindings/mfd/apple,smc.yaml +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml@@ -34,6 +34,10 @@ title: Apple Mac System Management Controller description: A phandle to the mailbox channel +patternProperties:
This is not a pattern, so "gpio" goes to "properties:".
+ gpio: + $ref: /schemas/gpio/gpio-macsmc.yaml + additionalProperties: false required:
Best regards, Krzysztof