Thread (15 messages) 15 messages, 3 authors, 2022-09-28

Re: [PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr'

flat view

From: Jianguo Zhang <hidden>
Date: 2022-09-28 07:44:10
Also in: linux-arm-kernel, linux-mediatek, lkml, netdev

Dear Krzysztof,

	Thanks for your comment.

On Wed, 2022-09-28 at 09:17 +0200, Krzysztof Kozlowski wrote:
On 27/09/2022 12:44, AngeloGioacchino Del Regno wrote:
quoted
quoted
quoted
OTOH, as Angelo pointed out, handling old and new properties is
quite
easy to achieve, so... :)
So, the conclusion is as following:

1. add new property 'snps,clk-csr' and document it in binding
file.
2. parse new property 'snps,clk-csr' firstly, if failed, fall
back to
old property 'clk_csr' in driver.

Is my understanding correct?
Yes, please.

I think that bindings should also get a 'clk_csr' with deprecated:
true,
but that's Krzysztof's call.
The property was never documented, so I think we can skip it as
deprecated.
We will send next version patches according to the conclusion.
Best regards,
Krzysztof
BRS
Jianguo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help