On 2022-08-30 at 09:25:47 +0000, Manne, Nava kishore wrote:

Hi Yilun,

	Please find my response inline. 

quoted

-----Original Message-----
From: Xu Yilun <yilun.xu@intel.com>
Sent: Saturday, August 27, 2022 11:52 AM
To: Manne, Nava kishore <redacted>
Cc: git (AMD-Xilinx) <redacted>; robh+dt@kernel.org;
krzysztof.kozlowski+dt@linaro.org; michal.simek@xilinx.com;
mdf@kernel.org; hao.wu@intel.com; trix@redhat.com;
p.zabel@pengutronix.de; gregkh@linuxfoundation.org;
ronak.jain@xilinx.com; rajan.vaja@xilinx.com;
abhyuday.godhasara@xilinx.com; piyush.mehta@xilinx.com;
lakshmi.sai.krishna.potthuri@xilinx.com; harsha.harsha@xilinx.com;
linus.walleij@linaro.org; nava.manne@xilinx.com;
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; linux-fpga@vger.kernel.org; yilun.xu@intel.com
Subject: Re: [PATCH 1/4] firmware: xilinx: Add afi ioctl support

On 2022-08-24 at 09:25:39 +0530, Nava kishore Manne wrote:

quoted

Adds afi ioctl to support dynamic PS-PL bus width settings.

Please also describe what is afi, PS, PL here, Patch #0 won't appear in
upstream tree finally.

Agree, Will update the description in v2.

quoted

Thanks,
Yilun

quoted

Signed-off-by: Nava kishore Manne <redacted>
---
 drivers/firmware/xilinx/zynqmp.c     | 14 +++++++++++
 include/linux/firmware/xlnx-zynqmp.h | 36
++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+)

diff --git a/drivers/firmware/xilinx/zynqmp.c

b/drivers/firmware/xilinx/zynqmp.c
index d1f652802181..cbd84c96a66a 100644

--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c

@@ -843,6 +843,20 @@ int zynqmp_pm_read_pggs(u32 index, u32

*value)  }

quoted

EXPORT_SYMBOL_GPL(zynqmp_pm_read_pggs);

+/**
+ * zynqmp_pm_afi() - PM API for setting the PS-PL bus width
+ * @config_id:	Register index value
+ * @bus_width:	Afi interface bus width value.
+ *
+ * Return:	Returns status, either success or error+reason

I see other functions are also like this, but I still can't figure out what values
for success and what for error+reason.

Please find the relevant error info here:
https://elixir.bootlin.com/linux/v6.0-rc3/source/drivers/firmware/xilinx/zynqmp.c#L81

The caller should at least know what value is success and what are
failures from the kernel doc, so they could write the code which call
your API.

Thanks,
Yilun

Regards,
Navakishore.