Re: [PATCH 02/15] dt-bindings: clocks: qcom,mmcc: define clocks/clock-names for MSM8960

On 25/06/2022 03:00, Dmitry Baryshkov wrote:

On Fri, 24 Jun 2022 at 18:57, Krzysztof Kozlowski
[off-list ref] wrote:

quoted

On 23/06/2022 14:04, Dmitry Baryshkov wrote:

quoted

Define clock/clock-names properties of the MMCC device node to be used
on MSM8960/APQ8064 platform.

Signed-off-by: Dmitry Baryshkov <redacted>
---
  .../devicetree/bindings/clock/qcom,mmcc.yaml  | 31 +++++++++++++++++++
  1 file changed, 31 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
index d02fe6dc79b5..c13243682365 100644
--- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml

@@ -82,6 +82,37 @@ then:
      - clock-names

  allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,mmcc-apq8064
+              - qcom,mmcc-msm8960
+    then:
+      properties:
+        clocks:
+          items:
+            - description: Board PXO source
+            - description: PLL 3 clock
+            - description: PLL 3 Vote clock
+            - description: DSI phy instance 1 dsi clock
+            - description: DSI phy instance 1 byte clock
+            - description: DSI phy instance 2 dsi clock
+            - description: DSI phy instance 2 byte clock
+            - description: HDMI phy PLL clock
+
+        clock-names:
+          items:
+            - const: pxo
+            - const: pll3
+            - const: pll8_vote
+            - const: dsi1pll
+            - const: dsi1pllbyte
+            - const: dsi2pll
+            - const: dsi2pllbyte
+            - const: hdmipll

The clocks are listed in properties, so they have min/max constraints
set implicitly. Are you sure this now works fine?

I mentioned this while listing dependencies in the patchset description (00/15):

Dependencies: [1] (whole series), [2], [3]
[...]
[2] https://lore.kernel.org/linux-arm-msm/20220617122922.769562-2-dmitry.baryshkov@linaro.org/ (local)

This patch moves clocks/clock-names to the conditional clause.

Krzysztof, as now the dependencies have landed into Bjorn's tree, could 
you please take another glance onto the bindings?

-- 
With best wishes
Dmitry