-----Original Message-----
From: Andy Shevchenko <redacted>
Sent: Monday, July 25, 2022 10:32 PM
To: kernel test robot <redacted>
Cc: Sa, Nuno <Nuno.Sa@analog.com>; linux-input <linux-
input@vger.kernel.org>; open list:GPIO SUBSYSTEM <linux-
gpio@vger.kernel.org>; devicetree [off-list ref];
llvm@lists.linux.dev; kbuild-all@lists.01.org; Linus Walleij
[off-list ref]; Krzysztof Kozlowski [off-list ref];
Hennerich, Michael [off-list ref]; Bartosz
Golaszewski [off-list ref]; Rob Herring [off-list ref];
Dmitry Torokhov [off-list ref]
Subject: Re: [PATCH v3 01/10] input: keyboard: adp5588-keys: support
gpi key events as 'gpio keys'

[External]

On Sat, Jul 23, 2022 at 6:57 AM kernel test robot [off-list ref]
wrote:


...

quoted

All warnings (new ones prefixed by >>):

quoted

quoted

drivers/input/keyboard/adp5588-keys.c:336:9: warning: implicit

conversion from 'unsigned long' to 'int' changes value from
18446744073709551615 to -1 [-Wconstant-conversion]

quoted

           return INVALID_HWIRQ;
           ~~~~~~ ^~~~~~~~~~~~~
   include/linux/irq.h:1245:24: note: expanded from macro

'INVALID_HWIRQ'

quoted

   #define INVALID_HWIRQ   (~0UL)
                            ^~~~

It requires irq.h, but hold on. Marc said that he wants to rather kill
that definition than having it spread over the kernel. So, please use
your own custom macro with an appropriate type.

I see, I'll probably just replicate the macro with an "ADP5588" prefix...

Thx,
- Nuno Sá