Re: [PATCH v4 3/8] dt-bindings: clock: Add ids for Lynx 10g PLLs
flat view
From: Krzysztof Kozlowski <hidden>
Date: 2022-08-05 06:53:30
Also in:
linux-arm-kernel, linux-clk, linux-phy, linuxppc-dev
On 05/08/2022 00:05, Sean Anderson wrote:
quoted hunk ↗ jump to hunk
This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used witn assigned-clock* to specify a particular frequency to use. Signed-off-by: Sean Anderson <redacted> --- Changes in v4: - New include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.hdiff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h new file mode 100644 index 000000000000..f5b955658106 --- /dev/null +++ b/include/dt-bindings/clock/fsl,lynx-10g.h@@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */
This should be dual license.
+/* + * Copyright (C) 2022 Sean Anderson [off-list ref]
It's confusing to see personal copyrights with company email. Either the copyright is attributed to your employer or to you. If to you, use private email.
quoted hunk ↗ jump to hunk
+ */ + +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H +#define __DT_BINDINGS_CLK_LYNX_10G_H + +#define LYNX10G_CLKS_PER_PLL 2 + +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1)
These do not look like proper IDs for clocks for bindings. Numbering starts from 0 or 1 and any "a" needs to be clearly explained. What do you bind here?
+ +#endif /* __DT_BINDINGS_CLK_LYNX_10G_H */
Best regards, Krzysztof