On 30/08/2022 19:10, Doug Anderson wrote:

Hi,

On Tue, Aug 30, 2022 at 2:33 AM Krzysztof Kozlowski
[off-list ref] wrote:

quoted

quoted

+};
+
+/*
+ * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES

What does it mean and why it's SCREAMING?

quoted

+ *
+ * Sort order matches the order in the parent files (parents before children).

Why? Sorting should be rather alphabetical.

We've had this discussion on the lists in the past. See, for instance:

https://lore.kernel.org/r/CAD=FV=U2C1W+JHWyGRfyRB=WiPKLYvtjO90UDoJ9p+Xwe09+ow@mail.gmail.com/ (local)

Good explanation, such sorting rule is quite nice. The part about
regulators is still a bit confusing, I guess it is about some other
pieces in some other place? But isn't this kind of obvious from
including other DTSI?

Best regards,
Krzysztof