Re: [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix
From: Johan Hovold <johan@kernel.org>
Date: 2022-08-30 07:43:46
Also in:
linux-arm-msm, linux-phy, lkml
On Tue, Aug 30, 2022 at 12:58:21PM +0530, Vinod Koul wrote:
On 30-08-22, 09:01, Johan Hovold wrote:quoted
On Tue, Aug 30, 2022 at 10:36:43AM +0530, Vinod Koul wrote:quoted
On 14-07-22, 14:43, Johan Hovold wrote:quoted
When adding support for SC8280XP to the QMP PHY driver I noticed that the PHY provider child node was not described by the current DT schema. The SC8280XP PHYs also need a second fixed-divider PIPE clock ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to the clock name just to match the current "pipe0" name so I decided to deprecate the unnecessary suffix in the current binding instead. To be able to add the missing child-node schema and handle device specifics like additional PIPE clocks, it quickly became obvious that the binding needs to be split up. This series clean up and fixes some issue with the current schema before splitting it up in separate schemas for PCIe, UFS and USB and adding missing parts like the child PHY provider nodes. The MSM8996 PCIe PHY gets its own schema as this is the only non-combo PHY that actually provides more than one PHY per IP block. Note that the "lane" suffix is still unnecessary and misleading. The final patches add support for the updated binding to the (recently split up) PHY drivers. Included is also a related combo PHY cleanup.This fails at patch 2 for me on v6.0-rc1, please rebase and resendAre you sure you haven't applied anything to your local tree that causes this?Pretty sure :-)
Hmm. But nothing had changed in 6.0-rc1 and it still applies on a clean 6.0-rc1 as expected here. Would you mind trying again? git checkout -b tmp-branch v6.0-rc1 b4 am 20220714124333.27643-1-johan+linaro@kernel.org git am ./v3_20220714_johan_linaro_phy_qcom_qmp_fix_dt_bindings_and_deprecate_lane_suffix.mbx
quoted
I just tried fetching the v3 series from lore and it applies just fine on top of 6.0-rc1. Note that if you've added a new compatible string locally, the second patch which sorts the compatible strings is likely to fail to apply.At that time no, now I think I have patch or so ... Tree should be pushed in a bit, you can check
Which tree would that be? The linux-phy tree next branch is still at -rc1: https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/ Johan