Thread (23 messages) 23 messages, 4 authors, 2022-08-25

Re: [PATCH v6 01/20] dt-bindings: iommu: mediatek: Increase max interrupt number

From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2022-08-25 13:41:10
Also in: linux-arm-kernel, linux-iommu, linux-mediatek, lkml


On 11/08/2022 04:57, Tinghan Shen wrote:
mt8195 infra iommu uses 5 interrupts.

Signed-off-by: Tinghan Shen <redacted>
Reviewed-by: Krzysztof Kozlowski <redacted>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Joerg, will you take this through your tree or shall I take care of it?

Regards,
Matthias
quoted hunk ↗ jump to hunk
---
  .../bindings/iommu/mediatek,iommu.yaml        | 29 ++++++++++++++-----
  1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
index fee0241b50988..f5634c1642e20 100644
--- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
@@ -91,7 +91,8 @@ properties:
      maxItems: 1
  
    interrupts:
-    maxItems: 1
+    minItems: 1
+    maxItems: 5
  
    clocks:
      items:
@@ -183,14 +184,28 @@ allOf:
        required:
          - mediatek,infracfg
  
-  - if: # The IOMMUs don't have larbs.
-      not:
-        properties:
-          compatible:
-            contains:
-              const: mediatek,mt8195-iommu-infra
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: mediatek,mt8195-iommu-infra
  
      then:
+      properties:
+        interrupts:
+          description: The IOMMU has 5 banks. Each bank has its own interrupt.
+          items:
+            - description: The interrupt for IOMMU bank0
+            - description: The interrupt for IOMMU bank1
+            - description: The interrupt for IOMMU bank2
+            - description: The interrupt for IOMMU bank3
+            - description: The interrupt for IOMMU bank4
+
+    else: # For the MM IOMMU
+      properties:
+        interrupts:
+          maxItems: 1
+
        required:
          - mediatek,larbs
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help