Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on rk3399
From: Heiko Stübner <heiko@sntech.de>
Date: 2022-08-23 15:51:14
Also in:
linux-arm-kernel, linux-rockchip, lkml
Am Montag, 22. August 2022, 09:41:39 CEST schrieb Jensen Huang:
Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.
Tested on NanoPC-T4.
Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts")
Signed-off-by: Jensen Huang <redacted>ok, so this looks like it restores previous functionality. I'm just wondering as the "offending" patch is from 2020, why this only turns up now. Any ideas?
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 9d5b0e8c9cca..9491cafbbaa3 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi@@ -1561,6 +1561,7 @@ emmc_phy: phy@f780 { clock-names = "emmcclk"; drive-impedance-ohm = <50>; #phy-cells = <0>; + rockchip,enable-strobe-pulldown; status = "disabled"; };