Re: [PATCH 2/4] soc: qcom: pmic_glink: Introduce base PMIC GLINK driver
From: Krzysztof Kozlowski <hidden>
Date: 2022-08-18 08:05:36
Also in:
linux-arm-msm, linux-pm, lkml
On 18/08/2022 06:15, Bjorn Andersson wrote:
The PMIC GLINK service runs on one of the co-processors of some modern Qualcomm platforms and implements USB-C and battery managements. It uses a message based protocol over GLINK for communication with the OS, hence the name. The driver implemented provides the rpmsg device for communication and uses auxilirary bus to spawn off individual devices in respsective
typos: auxiliary respective
subsystem. The auxilirary devices are spawned off from a
auxiliary
platform_device, so that the drm_bridge is available early, to allow the DisplayPort driver to probe even before the remoteproc has spun up.
(...)
+
+static int pmic_glink_init(void)
+{
+ platform_driver_register(&pmic_glink_driver);
+ register_rpmsg_driver(&pmic_glink_rpmsg_driver);
+
+ return 0;
+};
+module_init(pmic_glink_init);
+
+static void pmic_glink_exit(void)
+{
+ platform_driver_unregister(&pmic_glink_driver);
+ unregister_rpmsg_driver(&pmic_glink_rpmsg_driver);Shouldn't this be in reversed order of init()? So first unregister rpmsg, then platform driver.
quoted hunk ↗ jump to hunk
+}; +module_exit(pmic_glink_exit); + +MODULE_DESCRIPTION("Qualcomm PMIC GLINK driver"); +MODULE_LICENSE("GPL");diff --git a/include/linux/soc/qcom/pmic_glink.h b/include/linux/soc/qcom/pmic_glink.h new file mode 100644 index 000000000000..40470f8dfc1e --- /dev/null +++ b/include/linux/soc/qcom/pmic_glink.h@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2022, Linaro Ltd + */ +#ifndef __PMIC_GLINK_H__
I propose more detailed guard: __SOC_QCOM_PMIC_GLINK_H__
+#define __PMIC_GLINK_H__
Best regards, Krzysztof