ma 15. elok. 2022 klo 9.11 ChiYuan Huang (u0084500@gmail.com) kirjoitti:

Matti Vaittinen [off-list ref] 於 2022年8月15日 週一 下午1:53寫道：

quoted

Hi ChiYuan,

Thanks for the patch :)

to 11. elok. 2022 klo 16.43 cy_huang (u0084500@gmail.com) kirjoitti:

quoted

From: ChiYuan Huang <redacted>

Add support for the RT9471 3A 1-Cell Li+ battery charger.

The RT9471 is a highly-integrated 3A switch mode battery charger with
low impedance power path to better optimize the charging efficiency.

Co-developed-by: Alina Yu <redacted>
Signed-off-by: Alina Yu <redacted>
Signed-off-by: ChiYuan Huang <redacted>
---

quoted

While skimming through the rest of the patch... This may just be my
personal preference but wrapper functions with just one line are
rarely beneficial. In the worst case they just add more lines AND hide
the details of what actually is done without any clear benefits. Well,
this is just my view so please ignore this comment if wrappers like
this are a "subsystem standard"

I'm not sure what the 'subsystem standard' is.
I declare it as 'inline' function and the  function name to tell the
user what I'm doing.
This may be silly. But from my aspect, it makes each property set/get
more clear.

I guess this is Ok if the maintainer does not complain. And if he does
- then we at least know the "subsystem standard" ;)

Yours
  -- Matti
-- 

Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~