Thread (44 messages) 44 messages, 3 authors, 2022-10-24

Re: [PATCH V3 5/6] arm64: dts: meson: add S4 Soc Peripheral clock controller in DT

From: Yu Tu <hidden>
Date: 2022-08-08 10:02:28
Also in: linux-amlogic, linux-arm-kernel, linux-clk, lkml


On 2022/8/8 14:17, Krzysztof Kozlowski wrote:
[ EXTERNAL EMAIL ]

On 05/08/2022 11:36, Yu Tu wrote:
quoted
quoted
quoted
@@ -100,6 +102,30 @@ clkc_pll: pll-clock-controller@8000 {
   				#clock-cells = <1>;
   			};
   
+			clkc_periphs: periphs-clock-controller {
Node names should be generic, so "clock-controller"
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

You miss here unit address. Test your DTS with dtbs check and with
regular compile with W=1.
I will change to clkc_periphs: clock-controller@0 {.
Is that okay?
I cut the context, so if "0" was the value in reg, then it is OK.
Ok, I got it.I will change in next version.
Best regards,
Krzysztof

.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help