Re: [PATCH V2 1/3] dt-bindings: clk: meson: add S4 SoC clock controller bindings

On 28/07/2022 12:05, Yu Tu wrote:

Hi Krzysztof,
	Thanks for your reply.

On 2022/7/28 16:41, Krzysztof Kozlowski wrote:

quoted

[ EXTERNAL EMAIL ]

On 28/07/2022 07:42, Yu Tu wrote:

quoted

Add new clock controller compatible and dt-bindings header for the
Everything-Else domain of the S4 SoC.

Signed-off-by: Yu Tu <redacted>

quoted

diff --git a/MAINTAINERS b/MAINTAINERS
index c1abc53f9e91..f872d0c0c253 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS

@@ -1775,6 +1775,7 @@ F:	Documentation/devicetree/bindings/clock/amlogic*
  F:	drivers/clk/meson/
  F:	include/dt-bindings/clock/gxbb*
  F:	include/dt-bindings/clock/meson*
+F:	include/dt-bindings/clock/s4-clkc.h
  
  ARM/Amlogic Meson SoC Crypto Drivers
  M:	Corentin Labbe <clabbe@baylibre.com>

diff --git a/include/dt-bindings/clock/s4-clkc.h b/include/dt-bindings/clock/s4-clkc.h
new file mode 100644
index 000000000000..b686c8877419
--- /dev/null
+++ b/include/dt-bindings/clock/s4-clkc.h

Filename with vendor prefix, so:
amlogic,s4-clkc.h

It's fine with me. It's mainly Jerome's opinion.

To clarify: I understand such naming might bring inconsistency, but we
want to bring some order in the bindings directories. They keep growing
and at some point the model names might start conflicting.


Best regards,
Krzysztof