Re: [PATCH v2 4/6] arm64: dts: mt8192: Add display nodes
From: Nícolas F. R. A. Prado <hidden>
Date: 2022-07-01 16:40:54
Also in:
linux-arm-kernel, linux-mediatek, lkml
On Fri, Jul 01, 2022 at 05:05:45PM +0800, Allen-KH Cheng wrote:
quoted hunk ↗ jump to hunk
Add display nodes and gce info for mt8192 SoC. GCE (Global Command Engine) properties to the display nodes in order to enable the usage of the CMDQ (Command Queue), which is required for operating the display. Signed-off-by: Allen-KH Cheng <redacted> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Nícolas F. R. A. Prado <redacted> --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 137 +++++++++++++++++++++++ 1 file changed, 137 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index a789b7c9b2af..c4dc8777f26c 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
[..]
+ rdma4: rdma@14015000 {
+ compatible = "mediatek,mt8192-disp-rdma";You added the fallback compatible on rdma0 but missing it on this node. Thanks, Nícolas
+ reg = <0 0x14015000 0 0x1000>;
+ interrupts = <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH 0>;
+ power-domains = <&spm MT8192_POWER_DOMAIN_DISP>;
+ clocks = <&mmsys CLK_MM_DISP_RDMA4>;
+ iommus = <&iommu0 M4U_PORT_L1_DISP_RDMA4>;
+ mediatek,rdma-fifo-size = <2048>;
+ mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x5000 0x1000>;
+ };
+
dpi0: dpi@14016000 {
compatible = "mediatek,mt8192-dpi";
reg = <0 0x14016000 0 0x1000>;
--
2.18.0