Thread (22 messages) 22 messages, 2 authors, 2022-06-07

RE: [PATCH v2 2/6] phy: samsung: ufs: constify samsung_ufs_phy_cfg

flat view

From: Chanho Park <hidden>
Date: 2022-06-02 13:04:25
Also in: linux-arm-kernel, linux-phy, linux-samsung-soc

quoted
@@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct
phy *phy)  static int samsung_ufs_phy_calibrate(struct phy *phy)  {
 	struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy);
-	struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
+	const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
This should be rather array of const pointers to const data.
The prototype of ufs_phy->cfg is 'const struct samsung_ufs_phy_cfg **' by this patch.
So, it should be,

const struct samsung_ufs_phy_cfg ** const cfgs = ufs_phy->cfg;

Best Regards,
Chanho Park
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help