Thread (12 messages) flat view 12 messages, 3 authors, 2022-06-02

RE: [PATCH 1/4] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array

From: Chanho Park <hidden>
Date: 2022-06-02 02:17:37
Also in: linux-arm-kernel, linux-phy

quoted
+    items:
+      - items:
+        - description: phandle for PMU system controller interface, used
to
quoted
+                       control pmu registers bits for ufs m-phy
Wrong indentation.
This will be fixed on the next patchset.
quoted
+        - description: offset of pmu control register for ufs m-phy
+    description:
+      can be phandle/offset pair. The offset can be optional.
You made offset required, not optional.  You need minItems:1 on the level
of second "items".
Thanks. I didn't know how I make such that.. I'll apply this to next patchset.
quoted
 required:
   - "#phy-cells"
@@ -63,7 +68,7 @@ examples:
         compatible = "samsung,exynos7-ufs-phy";
         reg = <0x15571800 0x240>;
         reg-names = "phy-pma";
-        samsung,pmu-syscon = <&pmu_system_controller>;
+        samsung,pmu-syscon = <&pmu_system_controller 0x720>;
This will be dropped as well.

Best Regards,
Chanho Park
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help