Re: [PATCH v2 3/5] pinctrl: mediatek: add rsel setting on mt8192
From: Guodong Liu <hidden>
Date: 2022-06-26 04:48:56
Also in:
linux-arm-kernel, linux-gpio, linux-mediatek, lkml
-----Original Message----- From: Nícolas F. R. A. Prado <redacted> To: Guodong Liu <redacted> Cc: Linus Walleij <redacted>, Rob Herring < robh+dt@kernel.org>, Matthias Brugger [off-list ref], Sean Wang [off-list ref], Sean Wang [off-list ref], Zhiyong Tao [off-list ref], linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2 3/5] pinctrl: mediatek: add rsel setting on mt8192 Date: Fri, 24 Jun 2022 11:29:26 -0400 Hi Guodong, thanks for the patch. Please see comments below. On Fri, Jun 24, 2022 at 09:36:58PM +0800, Guodong Liu wrote:
quoted hunk ↗ jump to hunk
1. I2C pins's resistance value can be controlled by rsel register. This patch provides rsel (resistance selection) setting on mt8192. 2. Also add the missing pull type array for mt8192 to document the pull type of each pin and prevent invalid pull type settings. Signed-off-by: Guodong Liu <redacted> --- drivers/pinctrl/mediatek/pinctrl-mt8192.c | 136 ++++++++++++++++++++++ 1 file changed, 136 insertions(+)diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.cb/drivers/pinctrl/mediatek/pinctrl-mt8192.c index efabeb422aea..ffb0b04f0e3c 100644--- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
<snip>
+ MTK_PULL_PU_PD_TYPE,/*100* MTK_PULL_PU_PD_TYPE,/*101*/ + MTK_PULL_PU_PD_TYPE,/*102* MTK_PULL_PU_PD_TYPE,/*103*/ + MTK_PULL_PU_PD_TYPE,/*104* MTK_PULL_PU_PD_TYPE,/*105*/ + MTK_PULL_PU_PD_TYPE,/*106* MTK_PULL_PU_PD_TYPE,/*107*/ + MTK_PULL_PU_PD_TYPE,/*108* MTK_PULL_PU_PD_TYPE,/*109*/ + MTK_PULL_PU_PD_TYPE,/*110* MTK_PULL_PU_PD_TYPE,/*111*/ + MTK_PULL_PU_PD_TYPE,/*112* MTK_PULL_PU_PD_TYPE,/*113*/ + MTK_PULL_PU_PD_TYPE,/*114* MTK_PULL_PU_PD_TYPE,/*115*/ + MTK_PULL_PU_PD_TYPE,/*116* MTK_PULL_PU_PD_TYPE,/*117*/
The comments on pins 100 - 116 are missing the closing '/', effectively commenting out pins 101 - 117 and leading to errors. Please fix this. Other than that, Fixed in next patch,thanks! Reviewed-by: Nícolas F. R. A. Prado <redacted> Tested-by: Nícolas F. R. A. Prado <redacted> Thanks, Nícolas