Re: [PATCH v4 19/23] ata: ahci: Add DWC AHCI SATA controller support

On 6/18/22 05:36, Serge Semin wrote:

On Thu, Jun 16, 2022 at 09:31:30AM +0900, Damien Le Moal wrote:

quoted

On 2022/06/16 6:30, Serge Semin wrote:

quoted

On Fri, Jun 10, 2022 at 04:34:13PM -0700, Randy Dunlap wrote:

quoted

Hi Serge,

On 6/10/22 14:58, Serge Semin wrote:

quoted

On Fri, Jun 10, 2022 at 09:34:46AM -0700, Randy Dunlap wrote:

quoted

Hi--

Hi Randy

quoted

On 6/10/22 01:17, Serge Semin wrote:

quoted

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index bb45a9c00514..95e0e022b5bb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig

@@ -176,6 +176,16 @@ config AHCI_DM816
 
 	  If unsure, say N.
 
+config AHCI_DWC
+	tristate "Synopsys DWC AHCI SATA support"
+	select SATA_HOST
+	default SATA_AHCI_PLATFORM

quoted

I don't think this needs to default to SATA_AHCI_PLATFORM.
It might build a driver that isn't needed.
And it's incompatible with "If unsure, say N."

Basically you are right, but this particular setting is connected with
the modification I've done in the drivers/ata/ahci_platform.c driver
in the framework of this commit. I've moved the "snps,spear-ahci" and
"snps,dwc-ahci" compatible devices support to the new driver. Thus
should I omit the SATA_AHCI_PLATFORM dependency their default kernel
configs will lack the corresponding controllers support. If it's not a
problem and we can rely on the kernel build system ability to ask
whether the new config needs to be set/cleared, then I would be very
happy to drop the default setting. What do you think?

quoted

I'd prefer to try it like that.
If it becomes a problem, we can go back to this v4 patch.

Agreed then (seeing Damien is silent about your comment).

quoted

I have not thought about it :)
I do not use SATA PLATFORM at all, so I am not familiar with its dependencies.
Will have a look and do my usual build tests anyway.

Ok. I'll be waiting for you reply in this regard the before
re-submitting the next series version.

Please send a fixed-up new version. I will use that to look at builds and
config dependencies.


-- 
Damien Le Moal
Western Digital Research