On Tue, 14 Jun 2022 08:49:03 +0000
[off-list ref] wrote:

On 11.06.2022 20:54, Jonathan Cameron wrote:

quoted

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Thu, 9 Jun 2022 11:32:04 +0300
Claudiu Beznea [off-list ref] wrote:
  

quoted

Simplify a bit the code in at91_adc_read_info_raw() by reducing the
number of lines of code.

Signed-off-by: Claudiu Beznea <redacted>  

I'm not convinced this is worth while, but there are some lesser
steps visible in this patch that probably are.

Given your earlier reorg to move at01_adc_adjust_val_osr() under the locks,
you can now move the locks to the caller, thus not needing to handle them
separately in all the exit paths.  

OK, I'll give it a try. With this, would you prefer to still keep this patch?

No. I don't think it will bring enough benefit for the loss of readability.
Having moved the locking, there will only be a few repeated lines.

Jonathan