Re: [PATCH 1/5] ARM: dts: Add clock-output-names for omap4
From: Stephen Boyd <sboyd@kernel.org>
Date: 2022-03-11 03:34:42
Also in:
linux-clk, linux-omap
Quoting Tony Lindgren (2022-02-04 00:43:35)
To stop using the non-standard node name based clock naming, let's first add the clock-output-names property. This allows us to stop using the internal legacy clock naming and unify the naming for the TI SoCs in the following patches. Note that we must wait on fixing the node naming issues until after the internal clock names have been updated to avoid adding name translation unnecessarily. Cc: Stephen Boyd <sboyd@kernel.org> Cc: Tero Kristo <kristo@kernel.org> Signed-off-by: Tony Lindgren <tony@atomide.com> ---
I assume I don't merge this through clk tree.
quoted hunk ↗ jump to hunk
arch/arm/boot/dts/omap443x-clocks.dtsi | 1 + arch/arm/boot/dts/omap446x-clocks.dtsi | 2 + arch/arm/boot/dts/omap44xx-clocks.dtsi | 165 +++++++++++++++++++++++++ 3 files changed, 168 insertions(+)diff --git a/arch/arm/boot/dts/omap443x-clocks.dtsi b/arch/arm/boot/dts/omap443x-clocks.dtsi --- a/arch/arm/boot/dts/omap443x-clocks.dtsi +++ b/arch/arm/boot/dts/omap443x-clocks.dtsi@@ -8,6 +8,7 @@ &prm_clocks { bandgap_fclk: bandgap_fclk@1888 { #clock-cells = <0>; compatible = "ti,gate-clock"; + clock-output-names = "bandgap_fclk";
At this point clock-output-names is basically a debug feature. It would be better to use clocks property in consumer nodes and then use clk_parent_data to link up the clk tree. Not sure if that matters here though? I can understand the desire to have "usable" names vs. some not very useful name be auto generated..
clocks = <&sys_32k_ck>;
ti,bit-shift = <8>;
reg = <0x1888>;