Thread (15 messages) 15 messages, 4 authors, 2022-03-07

Aw: Re: [PATCH v5 1/5] dt-bindings: ata: ahci-platform: Convert DT bindings to yaml

From: Frank Wunderlich <hidden>
Date: 2022-03-06 09:48:35
Also in: linux-arm-kernel, linux-ide, linux-rockchip, lkml

Hi Krzysztof,

have seen some warnings in Robs bot for arm.

imho have fixed them (and the indention you've mentioned already squashed) in my tree [1].

    add compatibles used together with generic-ahci
      - marvell,berlin2-ahci
      - qcom,apq8064-ahci
      - qcom,ipq806x-ahci
    increase reg-count to 2 (used in omap5-l4.dtsi)
    increase clock-count to 5 (used in qcom-apq8064.dtsi)

can i still add you reviewed-by to v6?

[1] https://github.com/frank-w/BPI-R2-4.14/commits/5.17-next-20220225

regards Frank

Gesendet: Samstag, 05. März 2022 um 18:43 Uhr
Von: "Krzysztof Kozlowski" [off-list ref]

Thanks for the changes, all look good except now I noticed that
indentation of example is unusual. It's not consistent. Starts with four
space (correct) but then goes to 7 spaces. Please adjust entire example
to use 4 spaces indentation.

With that:

Reviewed-by: Krzysztof Kozlowski <redacted>
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help