Thread (1 message) 1 message, 1 author, 2022-02-28

Re: [PATCH v7 2/2] Driver for ON Semi AR0521 camera sensor

From: Krzysztof Hałasa <khalasa@piap.pl>
Date: 2022-02-28 07:49:01
Also in: linux-media, lkml

Hi Sakari,

Sakari Ailus [off-list ref] writes:
quoted
quoted
quoted
+	// access the sensor only if it's powered up
/* This is the preferred comment style */
I keep forgetting about this. Maybe because most other code I work with
(not drivers/media) has already switched to // (single-line) comments.
The OF folks have shunned to the use of the iterative varants as that can
often lead to complicated parsing of the endpoints. As obtaining the
endpoint based on port and endpoint IDs works well in all cases I've
suggested people to use that. But as the backend, at least currently, uses
iterative functions, they're unlikely to disappear in the future.
I understand I should continue using fwnode_graph_get_endpoint_by_id(),
right?

Thanks.
-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help