Re: [PATCH v4 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
From: Guodong Liu <hidden>
Date: 2022-02-16 03:28:45
Also in:
linux-arm-kernel, linux-gpio, linux-mediatek, lkml
-----Original Message----- From: AngeloGioacchino Del Regno < angelogioacchino.delregno@collabora.com> To: Guodong Liu <redacted>, Linus Walleij < linus.walleij@linaro.org>, Rob Herring [off-list ref], Matthias Brugger [off-list ref], Sean Wang [off-list ref] Cc: Sean Wang <sean.wang@mediatek.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v4 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document Date: Mon, 14 Feb 2022 10:58:58 +0100 Il 14/02/22 04:06, Guodong Liu ha scritto:
quoted hunk ↗ jump to hunk
1. This patch adds pinctrl file for mt8186. 2. This patch adds mt8186 compatible node in binding document. Signed-off-by: Guodong Liu <redacted> --- .../bindings/pinctrl/pinctrl-mt8186.yaml | 302 +++++ include/dt-bindings/pinctrl/mt8186-pinfunc.h | 1174 +++++++++++++++++ 2 files changed, 1476 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.hdiff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl- mt8186.yaml new file mode 100644 index 000000000000..582d131af4e3--- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
...snip...
quoted hunk ↗ jump to hunk
diff --git a/include/dt-bindings/pinctrl/mt8186-pinfunc.hb/include/dt-bindings/pinctrl/mt8186-pinfunc.h new file mode 100644 index 000000000000..dcff86201a61--- /dev/null +++ b/include/dt-bindings/pinctrl/mt8186-pinfunc.h@@ -0,0 +1,1174 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (C) 2021 MediaTek Inc. + * Author: Guodong Liu <Guodong.Liu@mediatek.com> + * + */ +
Hello, I've just noticed that we have a typo here.... You wrote "MT8168", but this should be "MT8186" instead; please fix it. P.S.: I'm sorry for not seeing that before!
+#ifndef __MT8168_PINFUNC_H +#define __MT8168_PINFUNC_H +
..snip..
+ +#endif /* __MT8168-PINFUNC_H */
Thank you, Angelo Hello Angelo, we will update it for next version. Thanks Guodong