Thread (15 messages) 15 messages, 5 authors, 2022-02-16

Re: [PATCH v3 4/8] ARM: dts: bcm283x: fix ethernet node name

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2022-02-15 21:01:18
Also in: linux-arm-kernel, linux-omap, linux-samsung-soc, linux-tegra, linux-usb, lkml, netdev

On 2/15/22 12:09 AM, Oleksij Rempel wrote:
It should be "ethernet@x" instead of "usbether@x"

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
This looks like, a quick grep on the u-boot source code seems to suggest
that only one file is assuming that 'usbether@1' is to be used as a node
name and the error message does not even match the code it is patching:

board/liebherr/xea/xea.c:
  #ifdef CONFIG_OF_BOARD_SETUP
  static int fdt_fixup_l2switch(void *blob)
  {
          u8 ethaddr[6];
          int ret;

          if (eth_env_get_enetaddr("ethaddr", ethaddr)) {
                  ret = fdt_find_and_setprop(blob,

"/ahb@80080000/switch@800f0000",
                                             "local-mac-address",
ethaddr, 6, 1);
                  if (ret < 0)
                          printf("%s: can't find usbether@1 node: %d\n",
                                 __func__, ret);
          }

          return 0;
  }

I will wait for the other maintainers on the other patches to provide
some feedback, but if all is well, will apply this one soon.
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help