Re: [PATCH v7 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2022-02-07 07:33:05
Also in:
linux-serial, lkml
On Mon, Feb 07, 2022 at 01:58:01PM +0800, Hammer Hsieh wrote:
Add Sunplus SoC UART Driver
We need more of a changelog comment here please. Describe the hardware, what the new tty name you are using, and other stuff. Be descriptive.
quoted hunk ↗ jump to hunk
--- a/include/uapi/linux/serial_core.h +++ b/include/uapi/linux/serial_core.h@@ -274,4 +274,7 @@ /* Freescale LINFlexD UART */ #define PORT_LINFLEXUART 122 +/* Sunplus UART */ +#define PORT_SUNPLUS 123
Why is this needed? Are you going to require this in some userspace code? If not, please do not add it. thanks, greg k-h