Re: [PATCH v1, 7/8] media: uapi: Init VP9 stateless decode params

Hi Chen-Yu,

Thanks for your suggestion.
Send this patch again.
On Thu, 2022-01-27 at 17:23 +0800, Chen-Yu Tsai wrote:

Hi,

On Thu, Jan 27, 2022 at 10:56 AM Yunfei Dong <
yunfei.dong@mediatek.com> wrote:

quoted

Init some of VP9 frame decode params to default value.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>

Maybe add

Fixes: b88dbe38dca8 ("media: uapi: Add VP9 stateless decoder
controls")

Best Regards,
Yunfei Dong

quoted

---
 drivers/media/v4l2-core/v4l2-ctrls-core.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c

b/drivers/media/v4l2-core/v4l2-ctrls-core.c
index 54abe5245dcc..b25c77b8a445 100644

--- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c

@@ -112,6 +112,7 @@ static void std_init_compound(const struct

v4l2_ctrl *ctrl, u32 idx,
        struct v4l2_ctrl_mpeg2_picture *p_mpeg2_picture;
        struct v4l2_ctrl_mpeg2_quantisation *p_mpeg2_quant;
        struct v4l2_ctrl_vp8_frame *p_vp8_frame;
+       struct v4l2_ctrl_vp9_frame *p_vp9_frame;
        struct v4l2_ctrl_fwht_params *p_fwht_params;
        void *p = ptr.p + idx * ctrl->elem_size;

@@ -152,6 +153,13 @@ static void std_init_compound(const struct

v4l2_ctrl *ctrl, u32 idx,
                p_vp8_frame = p;
                p_vp8_frame->num_dct_parts = 1;
                break;
+       case V4L2_CTRL_TYPE_VP9_FRAME:
+               p_vp9_frame = p;
+               p_vp9_frame->profile = 0;
+               p_vp9_frame->bit_depth = 8;
+               p_vp9_frame->flags |=
V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
+                       V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING;
+               break;
        case V4L2_CTRL_TYPE_FWHT_PARAMS:
                p_fwht_params = p;
                p_fwht_params->version = V4L2_FWHT_VERSION;
--
2.25.1