Re: [PATCH v6 3/3] mmc: Add driver for LiteX's LiteSDCard interface

On Fri, Jan 07, 2022 at 07:12:43PM +0900, Stafford Horne wrote:

On Fri, Jan 07, 2022 at 10:36:12AM +0100, Geert Uytterhoeven wrote:

quoted

Hi Gabriel,

On Thu, Jan 6, 2022 at 11:50 PM Gabriel L. Somlo [off-list ref] wrote:

quoted

On Thu, Jan 06, 2022 at 08:19:39PM +0200, Andy Shevchenko wrote:

quoted

On Thu, Jan 6, 2022 at 7:48 PM Gabriel Somlo [off-list ref] wrote:

quoted

LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
that targets FPGAs. LiteSDCard is a small footprint, configurable
SDCard core commonly used in LiteX designs.

The driver was first written in May 2020 and has been maintained
cooperatively by the LiteX community. Thanks to all contributors!

quoted

+config MMC_LITEX
+       tristate "LiteX MMC Host Controller support"
+       depends on OF
+       depends on PPC_MICROWATT || LITEX || COMPILE_TEST
+       help
+         This selects support for the MMC Host Controller found in LiteX SoCs.
+
+         If unsure, say N.

What would be the module name if built as a module?

litex_mmc.ko -- why are you asking? I.e., should I mention that anywhere
in the Kconfig blurb (I don't see other blurbs doing that, fwiw)?

Many (most?) blurbs do mention the module name.

I was doubting this as well, but I searched and its true.  The text 'module will
be called' shows up many times, there is also different text.

 $ grep -r 'module will be called' drivers/ | wc
   1347    9023   9086

 $ grep -r 'tristate \"' drivers/ | wc
   7169   47486  521795

OK, so initially I quickly looked at a few entries before LiteX in the
drivers/mmc/host/Kconfig file, and saw nothing useful, and asked a
follow-up question... :)

Knowing the magic "module will be called" incantation to grep for helped,
and now I created a similar one for LiteSDCard's Kconfig entry, and lined
it up for v7.

Thanks to everyone who chimed in!

Best,
--Gabriel