Re: [PATCH v2 1/2] clk: qcom: Add display clock controller driver for QCM2290
From: Bjorn Andersson <hidden>
Date: 2021-12-15 03:39:56
Also in:
linux-arm-msm, linux-clk
On Thu 09 Dec 08:09 CST 2021, Loic Poulain wrote: [..]
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/qcom/dispcc-qcm2290.c b/drivers/clk/qcom/dispcc-qcm2290.c
[..]
+static struct clk_rcg2 disp_cc_mdss_mdp_clk_src = {
+ .cmd_rcgr = 0x2074,
+ .mnd_width = 0,
+ .hid_width = 5,
+ .parent_map = disp_cc_parent_map_3,
+ .freq_tbl = ftbl_disp_cc_mdss_mdp_clk_src,
+ .clkr.hw.init = &(struct clk_init_data){
+ .name = "disp_cc_mdss_mdp_clk_src",
+ .parent_data = disp_cc_parent_data_3,
+ .num_parents = ARRAY_SIZE(disp_cc_parent_data_3),
+ .flags = CLK_SET_RATE_PARENT,
+ .ops = &clk_rcg2_ops,Clocks that are marked enable_safe_config = true downstream needs to be parked onto a safe parent as they are being disabled. This is taken care of upstream by using clk_rcg2_shared_ops.
+ }, +}; +
[..]
quoted hunk ↗ jump to hunk
diff --git a/include/dt-bindings/clock/qcom,dispcc-qcm2290.h b/include/dt-bindings/clock/qcom,dispcc-qcm2290.h new file mode 100644 index 00000000..ef50c17 --- /dev/null +++ b/include/dt-bindings/clock/qcom,dispcc-qcm2290.h@@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2019, The Linux Foundation. All rights reserved. + */ + +#ifndef _DT_BINDINGS_CLK_QCOM_DISP_CC_SCUBA_H +#define _DT_BINDINGS_CLK_QCOM_DISP_CC_SCUBA_H
Please replace SCUBA here and can you please move the include file to the DT binding patch instead? Regards, Bjorn