Re: [PATCH 08/18] dt-bindings: display: rockchip: dw-hdmi: Add regulator support
From: Robin Murphy <robin.murphy@arm.com>
Date: 2021-12-08 16:35:52
Also in:
dri-devel, linux-arm-kernel, linux-rockchip
On 2021-12-08 15:12, Sascha Hauer wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml index 2ab6578033da2..b9dca49aa6e05 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml@@ -28,6 +28,12 @@ properties: reg-io-width: const: 4 + avdd-0v9-supply: + description: A 0.9V supply that powers up the SoC internal circuitry.
Might be worth calling out the actual pin name so it's abundantly clear for DT authors cross-referencing schematics. Annoyingly, some SoCs have HDMI_AVDD_1V0 instead of HDMI_AVDD_0V9 - I'm not sure it's worth splitting hairs that far in terms of the property name itself, but I'll leave that for others to decide.
+ avdd-1v8-supply: + description: A 1.8V supply that powers up the SoC internal circuitry.
At least HDMI_AVDD_1V8 seems more consistent. Thanks, Robin.
+
clocks:
minItems: 2
items: