Re: [PATCH v2 06/17] dt-bindings: rng: add bindings for microchip mpfs rng
From: Krzysztof Kozlowski <hidden>
Date: 2021-12-17 14:53:50
Also in:
linux-crypto, linux-gpio, linux-i2c, linux-pwm, linux-riscv, linux-rtc, linux-spi, linux-usb, lkml
On 17/12/2021 10:33, conor.dooley@microchip.com wrote:
quoted hunk ↗ jump to hunk
From: Conor Dooley <conor.dooley@microchip.com> Add device tree bindings for the hardware rng device accessed via the system services on the Microchip PolarFire SoC. Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- .../bindings/rng/microchip,mpfs-rng.yaml | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yamldiff --git a/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml b/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml new file mode 100644 index 000000000000..32cbc37c9292 --- /dev/null +++ b/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml@@ -0,0 +1,29 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/rng/microchip,mpfs-rng.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Microchip MPFS random number generator + +maintainers: + - Conor Dooley <conor.dooley@microchip.com> + +description: | + The hardware random number generator on the Polarfire SoC is + accessed via the mailbox interface provided by the system controller + +properties: + compatible: + const: microchip,mpfs-rng + +required: + - compatible + +additionalProperties: false + +examples: + - | + hwrandom: hwrandom {
Three topics: 1. Node name (as most of others are using): rng 2. skip the label, not helping in example. 3. This looks very simple, so I wonder if the bindings are complete. No IO space/address... How is it going to be instantiated?
+ compatible = "microchip,mpfs-rng"; + };
Best regards, Krzysztof