Re: [PATCH v3 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts
From: Anup Patel <anup@brainfault.org>
Date: 2021-12-17 12:48:57
Also in:
linux-riscv, lkml
On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven [off-list ref] wrote:
The number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make dtbs_check". Fix this by adding the missing "maxItems". As the architectural maximum is 4095 interrupts, using that as the limit would be unpractical. Hence limit it to 10 interrupts (two interrupts for a system management core, and two interrupts per core for other cores). This should be sufficient for now, and the limit can always be increased when the need arises.
Same comment as the PLIC DT binding patch. The "maxItems" should represent CLINT spec constraints so please don't add any synthetic value here. Regards, Anup
quoted hunk ↗ jump to hunk
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Rob Herring <robh@kernel.org> --- v3: - Add Acked-by, v2: - Split in two patches, - Improve patch description and document limit rationale. --- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml@@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 10 additionalProperties: false --2.25.1