Re: [PATCH 3/4] dt-bindings: i2c Add regulator to pca954x
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2021-12-14 11:37:44
Also in:
linux-i2c, lkml
Hi Patrick, Thank you for the patch. On Tue, Dec 14, 2021 at 10:50:20AM +0100, Patrick Rudolph wrote:
quoted hunk ↗ jump to hunk
Add a regulator called vcc and update the example. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> --- Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml index bd794cb80c11..5add7db02c0c 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml@@ -64,6 +64,9 @@ properties: description: if present, overrides i2c-mux-idle-disconnect $ref: /schemas/mux/mux-controller.yaml#/properties/idle-state + vcc-supply: + description: An optional voltage regulator supplying power to the chip.
The NXP datasheet names the supply VDD, could we use vdd-supply here ? I
also wouldn't call it ooptional (even if it effectively is from a DT
point of view as the property isn't listed as required), given that the
power supply isn't optional for the chip to function. How about the
following ?
vdd-supply:
description: The voltage regulator powering to the VDD supply.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
quoted hunk ↗ jump to hunk
+ required: - compatible - reg@@ -84,6 +87,8 @@ examples: #size-cells = <0>; reg = <0x74>; + vcc-supply = <&p3v3>; + interrupt-parent = <&ipic>; interrupts = <17 IRQ_TYPE_LEVEL_LOW>; interrupt-controller;
-- Regards, Laurent Pinchart