Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

From
Javier Martinez Canillas <javier@dowhile0.org>
Date
2021-12-14 08:37:46
Also in
dri-devel, lkml
Reply to
Rob Herring, 2021-12-13
On Mon, Dec 13, 2021 at 3:50 PM Rob Herring [off-list ref] wrote:
On Mon, Dec 13, 2021 at 5:30 AM Javier Martinez Canillas
[off-list ref] wrote:
[snip]
quoted
You are right that passing NULL is a safe code path for now due the
of_device_is_available(node) check, but that seems fragile to me since
just adding a similar debug output to of_platform_device_create()
could trigger the NULL pointer dereference.
All/most DT functions work with a NULL node ptr, so why should this
one be different?
If you are OK with the patch as is, then I won't object :)
Rob
Best regards,
Javier
Thread (16 messages) 16 messages, 4 authors, last reply 2021-12-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help