Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace

On Thu, Dec 09, 2021 at 08:38:57PM +0100, Pavel Machek wrote:

Hi!

quoted

quoted

+	memzero_explicit(kaddr, dice_rmem->size);
+	devm_memunmap(dice_misc.this_device, kaddr);

Do you really need to call memzero_explicit()?  This isn't "local"
memory, if the compiler "optimizes away" a normal call, it would be
_VERY_ broken.

For clearing secrets, I believe memzero_explicit is nice
documentation.

Only if it's really needed please.