Re: [PATCH net-next v6 5/6] stmmac: dwmac-mediatek: add support for mt8195
From: Biao Huang <hidden>
Date: 2021-12-08 05:34:38
Also in:
linux-arm-kernel, linux-mediatek, lkml, netdev
From: Biao Huang <hidden>
Date: 2021-12-08 05:34:38
Also in:
linux-arm-kernel, linux-mediatek, lkml, netdev
Dear Jakub, Thanks for your comments. On Tue, 2021-12-07 at 20:04 -0800, Jakub Kicinski wrote:
On Wed, 8 Dec 2021 11:03:53 +0800 Biao Huang wrote:quoted
Add Ethernet support for MediaTek SoCs from the mt8195 family. Signed-off-by: Biao Huang <redacted> Acked-by: AngeloGioacchino Del Regno < angelogioacchino.delregno@collabora.com>drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:439:3: warning: variable 'gtxc_delay_val' is uninitialized when used here [- Wuninitialized] gtxc_delay_val |= FIELD_PREP(MT8195_DLY_GTXC_ENABLE, !!mac_delay->tx_delay); ^~~~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:369:20: note: initialize the variable 'gtxc_delay_val' to silence this warning u32 gtxc_delay_val, delay_val = 0, rmii_delay_val = 0; ^ = 0 1 warning generated. drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:439:3: warning: variable 'gtxc_delay_val' is uninitialized when used here [- Wuninitialized] gtxc_delay_val |= FIELD_PREP(MT8195_DLY_GTXC_ENABLE, !!mac_delay->tx_delay); ^~~~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:369:20: note: initialize the variable 'gtxc_delay_val' to silence this warning u32 gtxc_delay_val, delay_val = 0, rmii_delay_val = 0; ^ = 0
I'll fix the uninitialized warning in next send.