Re: [PATCH net-next v6 4/4] net: ocelot: add FDMA support
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-12-08 03:45:23
Also in:
lkml, netdev
On Tue, 7 Dec 2021 16:48:39 +0100 Clément Léger wrote:
quoted hunk ↗ jump to hunk
+ * struct ocelot_fdma - FDMA struct + * + * @ocelot: Pointer to ocelot struct + * @base: base address of FDMA registers + * @irq: FDMA interrupt + * @ndev: Net device used to initialize NAPI + * @dcbs_base: Memory coherent DCBs + * @dcbs_dma_base: DMA base address of memory coherent DCBs + * @tx_ring: Injection ring + * @rx_ring: Extraction ring + */ +struct ocelot_fdma { + int irq; + struct net_device *ndev; + struct ocelot_fdma_dcb *dcbs_base; + dma_addr_t dcbs_dma_base; + struct ocelot_fdma_tx_ring tx_ring; + struct ocelot_fdma_rx_ring rx_ring; + struct napi_struct napi; + struct ocelot *ocelot;
one more nit: drivers/net/ethernet/mscc/ocelot_fdma.h:156: warning: Function parameter or member 'napi' not described in 'ocelot_fdma'