On Wed, Dec 1, 2021 at 11:15 AM Florian Fainelli [off-list ref] wrote:

On 12/1/21 6:33 AM, Rob Herring wrote:

quoted

On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote:

quoted

MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores
and will be needed in order to convert GENET to YAML in subsequent
changes.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
 1 file changed, 1 insertion(+)

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1561996


ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
      arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml
      arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml
      arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml
      arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml
      arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml
      arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml
      arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml
      arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml

ethernet@17020000: phy-handle: [[36], [37]] is too long
      arch/arm64/boot/dts/apm/apm-mustang.dt.yaml

ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
      arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml
      arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml

These are all pre-existing warnings, but we should be documenting speed
2500 in ethernet-controller.yaml, so I will add a patch towards that end.

Thanks.

The one for apm-mustand.dts however I am not sure how to best resolve
since it looks like there was an intention to provide two Ethernet PHYs
and presumably have the firmware prune the one that is not in use. I
don't even know if that platform is supported mainline anymore.

Unfortunately it is, barely. I just fixed a breakage I caused 2 years
ago and just now noticed. I would not worry about it for now.

Rob