Re: [PATCH v5 8/8] dt-bindings: net: dsa: qca8k: add LEDs definition example
From: Rob Herring <robh@kernel.org>
Date: 2021-11-28 23:14:08
Also in:
linux-doc, linux-leds, lkml, netdev
On Fri, Nov 12, 2021 at 04:35:57PM +0100, Ansuel Smith wrote:
quoted hunk ↗ jump to hunk
Add LEDs definition example for qca8k using the offload trigger as the default trigger and add all the supported offload triggers by the switch. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- .../devicetree/bindings/net/dsa/qca8k.yaml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml index 48de0ace265d..106d95adc1e8 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml@@ -64,6 +64,8 @@ properties: internal mdio access is used. With the legacy mapping the reg corresponding to the internal mdio is the switch reg with an offset of -1. + Each phy have at least 3 LEDs connected and can be declared + using the standard LEDs structure.
at most 3? As the example only has 2...
quoted hunk ↗ jump to hunk
properties: '#address-cells':@@ -340,6 +342,24 @@ examples: internal_phy_port1: ethernet-phy@0 { reg = <0>; + + leds { + led@0 { + reg = <0>; + color = <LED_COLOR_ID_WHITE>; + function = LED_FUNCTION_LAN; + function-enumerator = <1>; + linux,default-trigger = "offload-phy-activity";
function is intended to replace 'linux,default-trigger'.
+ };
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_AMBER>;
+ function = LED_FUNCTION_LAN;
+ function-enumerator = <1>;Should be a different value than led@0?
+ linux,default-trigger = "offload-phy-activity";
+ };
+ };
};
internal_phy_port2: ethernet-phy@1 {
--
2.32.0