Re: [PATCH] dt-bindings: timer: sifive,clint: Fix number of interrupts
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-11-26 09:05:56
Also in:
linux-riscv, lkml
On Thu, Nov 25, 2021 at 4:23 PM Geert Uytterhoeven [off-list ref] wrote:
quoted hunk ↗ jump to hunk
To improve human readability and enable automatic validation, the tuples in "interrupts-extended" properties should be grouped using angle brackets. As the DT bindings lack an upper bound on the number of interrupts, thus assuming one, proper grouping is currently flagged as an error. Fix this by adding the missing "maxItems", limiting it to 10 interrupts (two interrupts for a system management core, and two interrupts per core for other cores), which should be sufficient for now. Group the tuples in the example. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- .../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index a35952f487426988..55bec2d059807c48 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml@@ -43,6 +43,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 10
Cfr. Jessica's comment on my PLIC patch:
The maximum supported by the CLINT memory map is 8192.
Device-specific limits would be 4 for k210 and jh7100, and 10 for
fu540.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds