RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
From: Edwin Chiu 邱垂峰 <hidden>
Date: 2021-11-26 06:01:32
Also in:
linux-pm, lkml
Hi Rob: What is the status now? Are you agree my submit? 邱垂峰 EdwinChiu 智能運算專案 T: +886-3-5786005 ext.2590 edwin.chiu@sunplus.com 300 新竹科學園區創新一路19號
-----Original Message----- From: Edwin Chiu 邱垂峰 Sent: Monday, November 15, 2021 5:08 PM To: 'Rob Herring' <robh@kernel.org> Cc: Edwin chiu <redacted>; daniel.lezcano@linaro.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; rafael@kernel.org; linux-pm@vger.kernel.org Subject: RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml Hi Rob: Thanks your response. Reply your question as below:quoted
quoted
1) The checkpatch warning is WARNING: From:/Signed-off-by: email address mismatch: 'From: Edwinchiu [off-list ref]' != 'Signed-off-by: Edwin chiu [off-list ref]'quoted
==> I want explain to you that [off-list ref] is my email in the company, but it disagreeoperate by "git send-email".quoted
So I used [off-list ref] in my linux system to operate with "git send-email". Actually I checkpatch in my side was 0 error 0 warning.The email used to send and the author emails are independent in git. There should be a 'From:' line in the resulting patch when the sender and author don't match. Maybe you need to set sendemail.from config option to your corp email.==> Please understanding it is our company secure policy. It disagree operate by "git send-email". But I am pretty sure I can receive email on both edwin.chiu@sunplus.com and edwinchiu0505tw@gmail.com .quoted
quoted
2) Regarding to dtbs-check issue, your list warnings related to others company's yaml file, it not myyaml file case.quoted
What is the purpose you want? Or what should I do?You aren't adding anything custom, so why are you even adding the schema? arm/idle-states.yaml should be enough.===> Yes, I want to apply arm/idle-state structure to my idle function. I thought every function submit, all need edit yaml file together. Do you mean I can submit cpuidle-sunplus.c without my sunplus,idle-state.yaml ? On the other hand, I confirm my yaml file can pass dt_binding_check and dtbs_check as below: edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml DTEX Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dts DTC Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml CHECK Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml edwinchiu@scdiu3:~/code/code1/linux/kernel$ edwinchiu@scdiu3:~/code/code1/linux/kernel$ export ARCH=arm edwinchiu@scdiu3:~/code/code1/linux/kernel$ echo $ARCH arm edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml SYNC include/config/auto.conf.cmd SCHEMA Documentation/devicetree/bindings/processed-schema.json UPD include/config/kernel.release DTC arch/arm/boot/dts/sp7021-bpi-f2p.dtb DTC arch/arm/boot/dts/sp7021-bpi-f2s.dtb DTC arch/arm/boot/dts/sp7021-demov2.dtb DTC arch/arm/boot/dts/sp7021-demov3.dtb DTC arch/arm/boot/dts/sp7021-ev.dtb DTC arch/arm/boot/dts/sp7021-ev-ttl.dtb DTC arch/arm/boot/dts/sp7021-ltpp3g2revD.dtb DTC arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dtb DTC arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml CHECK arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml DTC arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml CHECK arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml DTC arch/arm/boot/dts/sp7021-demov2.dt.yaml CHECK arch/arm/boot/dts/sp7021-demov2.dt.yaml DTC arch/arm/boot/dts/sp7021-demov3.dt.yaml CHECK arch/arm/boot/dts/sp7021-demov3.dt.yaml DTC arch/arm/boot/dts/sp7021-ev.dt.yaml CHECK arch/arm/boot/dts/sp7021-ev.dt.yaml DTC arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml CHECK arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml DTC arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml CHECK arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml DTC arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml CHECK arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml edwinchiu@scdiu3:~/code/code1/linux/kernel$ 邱垂峰 EdwinChiu 智能運算專案 T: +886-3-5786005 ext.2590 edwin.chiu@sunplus.com 300 新竹科學園區創新一路19號quoted
-----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Saturday, November 13, 2021 6:59 AM To: Edwin Chiu 邱垂峰 <redacted> Cc: Edwin chiu <redacted>; daniel.lezcano@linaro.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; rafael@kernel.org; linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml On Tue, Nov 09, 2021 at 06:58:24AM +0000, Edwin Chiu 邱垂峰 wrote:quoted
Hi Rob: Look into the full log, it show you check 3 programs ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Context Check Description robh/checkpatch warning total: 0 errors, 1 warnings, 67 lines checked robh/dt-meta-schema success robh/dtbs-check fail build log ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1) The checkpatch warning is WARNING: From:/Signed-off-by: email address mismatch: 'From: Edwinchiu [off-list ref]' != 'Signed-off-by: Edwin chiu [off-list ref]'quoted
==> I want explain to you that [off-list ref] is my email in the company, but it disagreeoperate by "git send-email".quoted
So I used [off-list ref] in my linux system to operate with "git send-email". Actually I checkpatch in my side was 0 error 0 warning.The email used to send and the author emails are independent in git. There should be a 'From:' line in the resulting patch when the sender and author don't match. Maybe you need to set sendemail.from config option to your corp email.quoted
2) Regarding to dtbs-check issue, your list warnings related to others company's yaml file, it not myyaml file case.quoted
What is the purpose you want? Or what should I do?You aren't adding anything custom, so why are you even adding the schema? arm/idle-states.yaml should be enough.quoted
3) Execute=>make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplu s, idle-state.yaml There are many config select items…..I don't know how to select them. (I execute "make config " and "make all" were pass) Can you teach me how to do "make dtbs_check"?Did you read Documentation/devicetree/bindings/writing-schema.rst? To check all dts files (for an arch) and run the validation, do: make allmodconfig make dtbs_check Robquoted
邱垂峰 EdwinChiu 智能運算專案 T: +886-3-5786005 ext.2590 edwin.chiu@sunplus.com 300 新竹科學園區創新一路19號 -----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Monday, November 8, 2021 9:03 PM To: Edwin chiu <redacted> Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; rafael@kernel.org; linux-pm@vger.kernel.org; Edwin Chiu 邱垂峰 [off-list ref] Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml On Mon, 08 Nov 2021 15:55:09 +0800, Edwin chiu wrote:quoted
Add the compatible string for cpuidle state on sp7021 Signed-off-by: Edwin chiu <redacted> --- .../bindings/arm/sunplus/sunplus,idle-state.yaml | 55 ++++++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.y am lRunning 'make dtbs_check' with the schema in this patch gives the following warnings. Consider ifthey are expected or the schema is incorrect. These may not be new warnings.quoted
Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1552228 spc: compatible:0: 'arm,idle-state' was expected arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml spc: compatible: Additional items are not allowed ('arm,idle-state' was unexpected) arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml spc: compatible: ['qcom,idle-state-spc', 'arm,idle-state'] is too long arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml