25.11.2021 16:18, Mark Brown пишет:

On Thu, Nov 25, 2021 at 03:53:52PM +0300, Dmitry Osipenko wrote:

quoted

25.11.2021 15:28, Mark Brown пишет:

quoted

On Thu, Nov 25, 2021 at 03:04:35PM +0300, Dmitry Osipenko wrote:

quoted

quoted

quoted

This driver never worked before this patchset, hence there is nothing to
backport, this is explained in the cover letter. But in general you're
correct.

quoted

quoted

That's not going to stop the stable people backporting things, and I'd
guess it might've worked at some point on some systems - I'm not seeing
anything that jumps out as making the driver completely unworkable in
your patches.

quoted

I can change commit message with the "fix" word removed, this should
prevent patch from backporting.

I wouldn't count on it TBH.  In any case, definitely no need to resend
for this alone.

Alright, I'll keep this in mind for a potential v2. I guess Rob may ask
to remove the assigned-clocks from S/PDIF DT binding because I just
found that there is no needed to specify that property explicitly anymore.

quoted

This driver never worked in mainline because S/PDIF device was never
created, thus driver was never bound. Driver doesn't work properly
without this patch. Nobody used this driver as-is before this patchset.

Someone might've been using it with an out of tree board file, I guess
on an older stable at this point.

I'm very doubtful. Still, this patch could be easily backported because
all code refactoring changes that potentially may cause merge conflicts
are made after this patch. Ideally, if we really needed to backport this
patch, then it should've been one of the first patches as you suggested.