Thread (6 messages) 6 messages, 3 authors, 2021-11-25

Re: [PATCH] dt-bindings: sound: nvidia,tegra-audio: Convert multiple txt bindings to yaml

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-11-25 03:00:32
Also in: alsa-devel, linux-tegra, lkml

01.11.2021 23:42, Rob Herring пишет:
quoted
Convert Tegra audio complex with the
 * ALC5632
 * MAX98090
 * RT5640
 * RT5677
 * SGTL5000
 * TrimSlice
 * WM8753
 * WM8903
 * WM9712
codec to the YAML format.
Perhaps say why they can all be combined.

I don't think that really works because the properties which are valid 
varies. Specifically, the GPIO lines vary.

Instead, define a schema with all the common properties and then 
reference it.
Those GPIO lines should be more board-specific, rather than
CODEC-specific. Yes, some of GPIO lines may be unrelated to a specific
CODEC, but practically it's not worth the effort to split this binding
because of a couple optional GPIOs, IMO. We actually considered the
variant with the reference that you're suggesting and decided that it
should be unnecessary.

Are you insisting that the binding needs to be split?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help