Thread (3 messages) flat view 3 messages, 3 authors, 2021-12-01

Re: [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-11-24 21:35:35
Also in: lkml, netdev

On Wed, Nov 24, 2021 at 09:20:46PM +0100, David Heidelberg wrote:
Both are already used by HW and drivers inside Linux.

Fix warnings as:
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
        From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml

Signed-off-by: David Heidelberg <david@ixit.cz>
This is valid for the binding, but not all Linux implementations of
fixed-link support > 1G. Only the phylink one does. But that is
outside the scope of the binding document.

You probably should list all speeds in
drivers/net/phy/phy-core.c:phy_setting settings[]. They are all valid
when using phylink and fixed-link.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help